Proposing removal of env.configFilePath and env.secretsFilePath#120
Merged
nikolasrieble merged 1 commit intohashicorp:mainfrom Jul 1, 2025
USA-RedDragon:remove-local-files
Merged
Proposing removal of env.configFilePath and env.secretsFilePath#120nikolasrieble merged 1 commit intohashicorp:mainfrom USA-RedDragon:remove-local-files
env.configFilePath and env.secretsFilePath#120nikolasrieble merged 1 commit intohashicorp:mainfrom
USA-RedDragon:remove-local-files
Conversation
nikolasrieble
previously approved these changes
Jun 30, 2025
Contributor
There was a problem hiding this comment.
These were likely helpers that we added for our own developers convenience. As they are misleading for the customer, I agree with the proposal to remove them.
@USA-RedDragon Could you please resolve the merge conflicts? I will then happily merge.
These utilize `.Files.Get` in Helm Per the Helm docs (https://helm.sh/docs/chart_template_guide/accessing_files/): > Some files cannot be accessed through the .Files object, usually for security reasons. > Files outside of a Helm application subchart, including those of the parent, cannot be accessed Because of this, `.env.configFilePath` and `env.secretsFilePath` are only ever usable if you have a copy of this repo in your local directory when installing. When installing the Helm chart through the https://helm.releases.hashicorp.com release, because the chart is pulled from the HashiCorp repo, these files are not considered a part of the chart, causing `.env.configFilePath` and `env.secretsFilePath` to always be a no-op. This has caused confusion on a support ticket, so I propose we remove these two values entirely. Examples/proof: Working because we edit the chart itself (install `.`) ```bash echo 'TFE_HOSTNAME: "testing"' > env-config.yaml helm template tfe . --set "env.configFilePath=`pwd`/env-config.yaml" ``` Not working because we are pulling from the HashiCorp repo ```bash echo 'TFE_HOSTNAME: "testing"' > env-config.yaml helm template tfe hashicorp/terraform-enterprise --set "env.configFilePath=`pwd`/env-config.yaml" ```
Contributor
Author
|
I rebased the change on top of |
nikolasrieble
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121
I noticed while on a screen sharing session with a customer that these options do not work unless you
helm install .from a local copy of this chart. When utilized with our Helm registry, (i.e.helm install hashicorp/terraform-enterprise), no files outside of the ones already in this Git repo are able to be accessed.This is because these values utilize
.Files.Getin HelmPer the Helm docs (https://helm.sh/docs/chart_template_guide/accessing_files/):
Because of this,
.env.configFilePathandenv.secretsFilePathare only ever usable if you have a copy of this repo in your local directory when installing. When installing the Helm chart through the https://helm.releases.hashicorp.com release, because the chart is pulled from the HashiCorp repo, these files are not considered a part of the chart, causing.env.configFilePathandenv.secretsFilePathto always be a no-op.This has caused confusion on a support ticket, so I propose we remove these two values entirely.
Examples/proof:
Working because we edit the chart itself (install
.)Not working because we are pulling from the HashiCorp repo